Skip to content

GH-111438 add support for sharing floats #111439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericsnowcurrently merged 6 commits into from
Oct 31, 2023
Merged

GH-111438 add support for sharing floats #111439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9a6041b
add support for sharing floats
tonybaloney Oct 29, 2023
bfc06b3
update supported types in test
tonybaloney Oct 29, 2023
5ffbeb3
Update Python/pystate.c
tonybaloney Oct 30, 2023
5664b87
Style updates for PEP7
tonybaloney Oct 30, 2023
8b9d7b9
Merge remote-tracking branch 'origin/main' into HEAD
tonybaloney Oct 31, 2023
e4f201c
Add float type serialization to crossinterp
tonybaloney Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Lib/test/test__xxsubinterpreters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ def test_default_shareables(self):
'spam',
10,
-10,
100.0,
]
for obj in shareables:
with self.subTest(obj):
Expand Down Expand Up @@ -129,7 +130,6 @@ class SubBytes(bytes):
object,
object(),
Exception(),
100.0,
# user-defined types and objects
Cheese,
Cheese('Wensleydale'),
Expand Down Expand Up @@ -189,6 +189,9 @@ def test_non_shareable_int(self):
with self.assertRaises(OverflowError):
_testinternalcapi.get_crossinterp_data(i)

def test_float(self):
self._assert_values([0.0, 1.1, -1.0, 0.12345678, -0.12345678])


class ModuleTests(TestBase):

Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_interpreters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,6 +778,7 @@ def test_default_shareables(self):
'spam',
10,
-10,
100.0,
]
for obj in shareables:
with self.subTest(obj):
Expand Down Expand Up @@ -805,7 +806,6 @@ class SubBytes(bytes):
object,
object(),
Exception(),
100.0,
# user-defined types and objects
Cheese,
Cheese('Wensleydale'),
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core and Builtins/2023-10-29-12-33-33.gh-issue-111438.bHTLLl.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Added support for sharing of float type with interpreters API.
28 changes: 28 additions & 0 deletions Python/crossinterp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,6 +585,29 @@ _long_shared(PyThreadState *tstate, PyObject *obj,
return 0;
}

static PyObject *
_new_float_object(_PyCrossInterpreterData *data)
{
double * value_ptr = data->data;
return PyFloat_FromDouble(*value_ptr);
}

static int
_float_shared(PyThreadState *tstate, PyObject *obj,
_PyCrossInterpreterData *data)
{
if (_PyCrossInterpreterData_InitWithSize(
data, tstate->interp, sizeof(double), NULL,
_new_float_object
) < 0)
{
return -1;
}
double *shared = (double *)data->data;
*shared = PyFloat_AsDouble(obj);
return 0;
}

static PyObject *
_new_none_object(_PyCrossInterpreterData *data)
{
Expand Down Expand Up @@ -624,4 +647,9 @@ _register_builtins_for_crossinterpreter_data(struct _xidregistry *xidregistry)
if (_xidregistry_add_type(xidregistry, &PyUnicode_Type, _str_shared) != 0) {
Py_FatalError("could not register str for cross-interpreter sharing");
}

// float
if (_xidregistry_add_type(xidregistry, &PyFloat_Type, _float_shared) != 0) {
Py_FatalError("could not register float for cross-interpreter sharing");
}
}