Skip to content

gh-79177: Add name parameter to multiprocessing #110804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nanjekyejoannah wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-79177: Add name parameter to multiprocessing #110804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c350f12
Add name to name parameter to multiprocessing
nanjekyejoannah Oct 13, 2023
60912ab
📜🤖 Added by blurb_it.
blurb-it[bot] Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Doc/library/multiprocessing.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2775,7 +2775,7 @@ returns an instance of :class:`ThreadPool`, which is a subclass of
worker threads rather than worker processes.


.. class:: ThreadPool([processes[, initializer[, initargs]]])
.. class:: ThreadPool([processes[, initializer[, initargs[, name]]]])

A thread pool object which controls a pool of worker threads to which jobs
can be submitted. :class:`ThreadPool` instances are fully interface
Expand Down
17 changes: 12 additions & 5 deletions Lib/multiprocessing/pool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ def Process(ctx, *args, **kwds):
return ctx.Process(*args, **kwds)

def __init__(self, processes=None, initializer=None, initargs=(),
maxtasksperchild=None, context=None):
maxtasksperchild=None, context=None, name='Process-Pool'):
# Attributes initialized early to make sure that they exist in
# __del__() if __init__() raises an exception
self._pool = []
Expand All @@ -198,6 +198,7 @@ def __init__(self, processes=None, initializer=None, initargs=(),
self._maxtasksperchild = maxtasksperchild
self._initializer = initializer
self._initargs = initargs
self._name = name

if processes is None:
processes = os.process_cpu_count() or 1
Expand All @@ -224,6 +225,7 @@ def __init__(self, processes=None, initializer=None, initargs=(),
sentinels = self._get_sentinels()

self._worker_handler = threading.Thread(
name='{}-Worker-Handler'.format(self._name),
target=Pool._handle_workers,
args=(self._cache, self._taskqueue, self._ctx, self.Process,
self._processes, self._pool, self._inqueue, self._outqueue,
Expand All @@ -236,6 +238,7 @@ def __init__(self, processes=None, initializer=None, initargs=(),


self._task_handler = threading.Thread(
name='{}-Task-Handler'.format(self._name),
target=Pool._handle_tasks,
args=(self._taskqueue, self._quick_put, self._outqueue,
self._pool, self._cache)
Expand All @@ -245,6 +248,7 @@ def __init__(self, processes=None, initializer=None, initargs=(),
self._task_handler.start()

self._result_handler = threading.Thread(
name='{}-Result-Handler'.format(self._name),
target=Pool._handle_results,
args=(self._outqueue, self._quick_get, self._cache)
)
Expand Down Expand Up @@ -309,17 +313,20 @@ def _repopulate_pool(self):
self._outqueue, self._initializer,
self._initargs,
self._maxtasksperchild,
self._wrap_exception)
self._wrap_exception,
self._name)

@staticmethod
def _repopulate_pool_static(ctx, Process, processes, pool, inqueue,
outqueue, initializer, initargs,
maxtasksperchild, wrap_exception):
maxtasksperchild, wrap_exception,
name):
"""Bring the number of pool processes up to the specified number,
for use after reaping workers which have exited.
"""
for i in range(processes - len(pool)):
w = Process(ctx, target=worker,
name='{}-Worker-{}'.format(name, i),
args=(inqueue, outqueue,
initializer,
initargs, maxtasksperchild,
Expand Down Expand Up @@ -926,8 +933,8 @@ def Process(ctx, *args, **kwds):
from .dummy import Process
return Process(*args, **kwds)

def __init__(self, processes=None, initializer=None, initargs=()):
Pool.__init__(self, processes, initializer, initargs)
def __init__(self, processes=None, initializer=None, initargs=(), name='Thread-Pool'):
Pool.__init__(self, processes, initializer, initargs, name='Thread-Pool')

def _setup_queues(self):
self._inqueue = queue.SimpleQueue()
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core and Builtins/2023-10-13-06-46-00.gh-issue-79177.Y4AAxY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add name parameter to the multiprocessing module. Patch by Joannah Nanjekye.