Skip to content

bpo-35325:imp.find_module() return value documentation discrepancy#11040

Merged
JulienPalard merged 2 commits intopython:masterfrom
Windsooon:bpo-35325
Sep 12, 2019
Merged

bpo-35325:imp.find_module() return value documentation discrepancy#11040
JulienPalard merged 2 commits intopython:masterfrom
Windsooon:bpo-35325

Conversation

@Windsooon
Copy link
Copy Markdown
Contributor

@Windsooon Windsooon commented Dec 9, 2018 •
edited by bedevere-bot
Loading

I'm not sure we should keep the change in Doc/library/imp.rst, feel free to edit it.

https://bugs.python.org/issue35325

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Dec 9, 2018
ericsnowcurrently
ericsnowcurrently requested changes Dec 12, 2018
View reviewed changes
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Dec 12, 2018

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ericsnowcurrently
Copy link
Copy Markdown
Member

ericsnowcurrently commented Dec 12, 2018

You will want to add a NEWS entry. The "blurb" tool makes this easy. See the devguide for more info.

Please be sure to add yourself to Misc/ACKS (in this PR) if you aren't there already.

@vstinner
Copy link
Copy Markdown
Member

vstinner commented Jan 10, 2019

I removed the " needs backport to 3.6" label, the 3.6 branch no long accept bugfixes (only security fixes are accepted): https://devguide.python.org/#status-of-python-branches

@Windsooon
Copy link
Copy Markdown
Contributor Author

Windsooon commented Sep 12, 2019

I updated the PR based on @ericsnowcurrently 's review. Thank you.

@JulienPalard JulienPalard merged commit 967b84c into python:master Sep 12, 2019
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Sep 12, 2019

Thanks @Windsooon for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 12, 2019
@Windsooon @miss-islington
bpo-35325: Doc: imp.find_module() return value documentation discrepa…
2b9d229 
…ncy (pythonGH-11040)

(cherry picked from commit 967b84c)

Co-authored-by: Windson yang <wiwindson@outlook.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Sep 12, 2019

GH-16035 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Sep 12, 2019

GH-16036 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 12, 2019
@Windsooon @miss-islington
bpo-35325: Doc: imp.find_module() return value documentation discrepa…
d5b6e7e 
…ncy (pythonGH-11040)

(cherry picked from commit 967b84c)

Co-authored-by: Windson yang <wiwindson@outlook.com>
miss-islington added a commit that referenced this pull request Sep 12, 2019
@miss-islington @Windsooon
bpo-35325: Doc: imp.find_module() return value documentation discrepa…
01b47c9 
…ncy (GH-11040)

(cherry picked from commit 967b84c)

Co-authored-by: Windson yang <wiwindson@outlook.com>
miss-islington added a commit that referenced this pull request Sep 12, 2019
@miss-islington @Windsooon
bpo-35325: Doc: imp.find_module() return value documentation discrepa…
14afe20 
…ncy (GH-11040)

(cherry picked from commit 967b84c)

Co-authored-by: Windson yang <wiwindson@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JulienPalard JulienPalard JulienPalard left review comments

@ericsnowcurrently ericsnowcurrently ericsnowcurrently requested changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Windsooon @bedevere-bot @ericsnowcurrently @vstinner @miss-islington @JulienPalard @the-knights-who-say-ni