Skip to content

gh-110345: show Tcl/Tk patchlevel in tkinter._test()#110350

Merged
serhiy-storchaka merged 5 commits into
python:mainfrom
chrstphrchvz:patch-110345
Jan 18, 2024
Merged

gh-110345: show Tcl/Tk patchlevel in tkinter._test()#110350
serhiy-storchaka merged 5 commits into
python:mainfrom
chrstphrchvz:patch-110345

Conversation

@chrstphrchvz

@chrstphrchvz chrstphrchvz commented Oct 4, 2023 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-app bedevere-app Bot mentioned this pull request Oct 4, 2023
Closed
serhiy-storchaka
serhiy-storchaka approved these changes Jan 18, 2024
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka

serhiy-storchaka commented Jan 18, 2024

Copy link
Copy Markdown
Member

There is also info_patchlevel() method, but I think that it is better to use more low-level method here.

@serhiy-storchaka
serhiy-storchaka merged commit b8f29b1 into python:main Jan 18, 2024
@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jan 18, 2024
@miss-islington-app

miss-islington-app Bot commented Jan 18, 2024

Copy link
Copy Markdown

Thanks @chrstphrchvz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Jan 18, 2024

Copy link
Copy Markdown

Thanks @chrstphrchvz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 18, 2024
@chrstphrchvz @miss-islington
pythongh-110345: show Tcl/Tk patchlevel in tkinter._test() (pythonG…
b5d2851 
…H-110350)

(cherry picked from commit b8f29b1)

Co-authored-by: Christopher Chavez <chrischavez@gmx.us>
@bedevere-app

bedevere-app Bot commented Jan 18, 2024

Copy link
Copy Markdown

GH-114252 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Jan 18, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 18, 2024
@chrstphrchvz @miss-islington
pythongh-110345: show Tcl/Tk patchlevel in tkinter._test() (pythonG…
ef449d0 
…H-110350)

(cherry picked from commit b8f29b1)

Co-authored-by: Christopher Chavez <chrischavez@gmx.us>
@bedevere-app

bedevere-app Bot commented Jan 18, 2024

Copy link
Copy Markdown

GH-114253 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jan 18, 2024
serhiy-storchaka pushed a commit that referenced this pull request Jan 18, 2024
@miss-islington @chrstphrchvz
[3.11] gh-110345: show Tcl/Tk patchlevel in tkinter._test() (GH-110350
4bc0c07 
) (GH-114252)

(cherry picked from commit b8f29b1)

Co-authored-by: Christopher Chavez <chrischavez@gmx.us>
serhiy-storchaka pushed a commit that referenced this pull request Jan 18, 2024
@miss-islington @chrstphrchvz
[3.12] gh-110345: show Tcl/Tk patchlevel in tkinter._test() (GH-110350
6d23b32 
) (GH-114253)

(cherry picked from commit b8f29b1)

Co-authored-by: Christopher Chavez <chrischavez@gmx.us>
@bedevere-bot

bedevere-bot commented Jan 18, 2024

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Ubuntu Shared 3.11 has failed when building commit 4bc0c07.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/981/builds/1350) and take a look at the build logs.
  4. Check if the failure is related to this commit (4bc0c07) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/981/builds/1350

Summary of the results of the build (if available):

Click to see traceback logs 
remote: Enumerating objects: 10, done.        
remote: Counting objects:  11% (1/9)        
remote: Counting objects:  22% (2/9)        
remote: Counting objects:  33% (3/9)        
remote: Counting objects:  44% (4/9)        
remote: Counting objects:  55% (5/9)        
remote: Counting objects:  66% (6/9)        
remote: Counting objects:  77% (7/9)        
remote: Counting objects:  88% (8/9)        
remote: Counting objects: 100% (9/9)        
remote: Counting objects: 100% (9/9), done.        
remote: Total 10 (delta 8), reused 8 (delta 8), pack-reused 1        
From https://github.com/python/cpython
 * branch                  3.11       -> FETCH_HEAD
Note: switching to '4bc0c07051595511baf42e9534bfea4fb9203099'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 4bc0c07051 [3.11] gh-110345: show Tcl/Tk patchlevel in `tkinter._test()` (GH-110350) (GH-114252)
Switched to and reset branch '3.11'

configure: WARNING: pkg-config is missing. Some dependencies may not be detected correctly.

/tmp/ccjtgVfw.s: Assembler messages:
/tmp/ccjtgVfw.s: Fatal error: Objects/typeobject.o: No space left on device
make: *** [Makefile:2513: Objects/typeobject.o] Error 1

find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
make: [Makefile:2601: clean-retain-profile] Error 1 (ignored)

kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
@chrstphrchvz @kulikjak
pythongh-110345: show Tcl/Tk patchlevel in tkinter._test() (pythonG…
5df9548 
…H-110350)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@chrstphrchvz @aisk
pythongh-110345: show Tcl/Tk patchlevel in tkinter._test() (pythonG…
6f92460 
…H-110350)
@chrstphrchvz
chrstphrchvz deleted the patch-110345 branch February 14, 2024 13:23
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@chrstphrchvz @Glyphack
pythongh-110345: show Tcl/Tk patchlevel in tkinter._test() (pythonG…
a9321ec 
…H-110350)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

topic-tkinter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chrstphrchvz @serhiy-storchaka @bedevere-bot @encukou