Skip to content

gh-109118: Disallow nested scopes within PEP 695 scopes within classes #109196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 5 commits into from
Sep 12, 2023
Merged

gh-109118: Disallow nested scopes within PEP 695 scopes within classes #109196

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0e99835
New test
JelleZijlstra Sep 8, 2023
cb30ae1
more and more isolated tests
JelleZijlstra Sep 9, 2023
725ca36
Similar test with aliases, which already passes
JelleZijlstra Sep 9, 2023
d7be560
gh-109118: Disallow nested scopes within PEP 695 scopes within classes
JelleZijlstra Sep 9, 2023
ea69d36
Update Lib/test/test_type_params.py
JelleZijlstra Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Similar test with aliases, which already passes
  • Loading branch information
@JelleZijlstra
JelleZijlstra committed Sep 9, 2023
commit 725ca369637e11f1036b037bdd7419e3ab6b1100
24 changes: 24 additions & 0 deletions Lib/test/test_type_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,6 +472,30 @@ class Inner[U](make_base([T for _ in (1,)]), make_base(T)):
self.assertEqual(base1.__arg__, [T])
self.assertEqual(base2.__arg__, "class")

def test_lambda_in_generic_alias(self):
code = """
class C[T]:
T = "class"
type Alias1[T] = lambda: T
type Alias2 = lambda: T
type Alias3[T] = (T for _ in (1,))
type Alias4 = (T for _ in (1,))
type Alias5[T] = [T for _ in (1,)]
type Alias6 = [T for _ in (1,)]
"""
C = run_code(code)["C"]
outer_T = C.__type_params__[0]
T1 = C.Alias1.__type_params__[0]
self.assertIs(C.Alias1.__value__(), T1)
# Shouldn't pick up the T from the class scope
self.assertIs(C.Alias2.__value__(), outer_T)
T3 = C.Alias3.__type_params__[0]
self.assertEqual(list(C.Alias3.__value__), [T3])
self.assertEqual(list(C.Alias4.__value__), [outer_T])
T5 = C.Alias5.__type_params__[0]
self.assertEqual(C.Alias5.__value__, [T5])
self.assertEqual(C.Alias6.__value__, [outer_T])


def make_base(arg):
class Base:
Expand Down