bpo-35341: Add generic version of OrderedDict to typing#10850
Merged
Conversation
tirkarthi
reviewed
Dec 2, 2018
Member
|
Sorry, I missed the docs part. This would require some docs to be added about the new addition at https://github.com/python/cpython/blob/master/Doc/library/typing.rst#classes-functions-and-decorators that contains the current set of items. I will leave it to the reviewers on the content of the docs. |
Contributor
Author
|
Added docs based on the ones for |
ilevkivskyi
reviewed
Dec 2, 2018
ilevkivskyi
left a comment
ilevkivskyi
left a comment
Member
There was a problem hiding this comment.
Thanks for PR, just one little comment.
| @@ -0,0 +1 @@ | |||
| Add generic version of ``collections.OrderedDict`` to the ``typing`` module. | |||
ilevkivskyi
approved these changes
Dec 2, 2018
Contributor
|
Thanks @itoijala for the PR, and @ilevkivskyi for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-10851 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 2, 2018
(cherry picked from commit 68b56d0) Co-authored-by: Ismo Toijala <ismo.toijala@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Dec 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a generic version of OrderedDict to the typing module.
A backport to 3.7 was stated to be possible in the issue.
I would like to request such a backport to get this in 3.7.2.
https://bugs.python.org/issue35341