gh-106149: move CFG and basicblock definitions into flowgraph.c, use them as opaque types in compile.c #107639
+482
−478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iritkatriel
added
the
🔨 test-with-refleak-buildbots
|
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit c05fa8e 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-refleak-buildbots
Member
Author
|
The ref leaks failures are unrelated to this PR. |
Member
|
Looks good to me, although I've not checked every detail as I assume it is a refactor, with no change to behavior. @iritkatriel Can you confirm that this is strictly a refactor? |
Member
Author
Yes It basically moves code from compile.c to flowgraph.c, and struct definitions from the header into flowgraph.c, and then changes some of the functions from private (declared in the header) to static in flowgraph.c. |
markshannon
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves all the code that manipulates the CFG to flowgraph.c.