Add assertion to _PyTuple_CAST(op)#10712
Merged
vstinner merged 2 commits intopython:masterfrom Nov 26, 2018
vstinner:tuple_cast_assert
Merged
Add assertion to _PyTuple_CAST(op)#10712vstinner merged 2 commits intopython:masterfrom vstinner:tuple_cast_assert
vstinner merged 2 commits intopython:masterfrom
vstinner:tuple_cast_assert
Conversation
Add "assert(PyTuple_Check(op))" to _PyTuple_CAST() to check that the argument is a tuple object in debug mode. PyTuple_GET_SIZE() now uses _PyTuple_CAST() to use its assertion.
Member
Author
|
@serhiy-storchaka: What do you think of checking that the first argument of |
Member
|
This LGTM. But I don't think that such verbose and trivial comment is needed. Other macros (like I would add an assert in |
Member
Author
|
Ok, I removed the comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add "assert(PyTuple_Check(op))" to _PyTuple_CAST() to check that the
argument is a tuple object in debug mode.
PyTuple_GET_SIZE() now uses _PyTuple_CAST() to use its assertion.