Skip to content

gh-107015: Remove async_hacks from the tokenizer#107018

Merged
pablogsal merged 3 commits into
python:mainfrom
pablogsal:gh-107015
Jul 26, 2023
Merged

gh-107015: Remove async_hacks from the tokenizer#107018
pablogsal merged 3 commits into
python:mainfrom
pablogsal:gh-107015

Conversation

@pablogsal

@pablogsal pablogsal commented Jul 22, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@pablogsal
pablogsal requested a review from lysnikolaou as a code owner July 22, 2023 12:36
@bedevere-bot bedevere-bot mentioned this pull request Jul 22, 2023
Closed
@pablogsal
pythongh-107015: Remove async_hacks from the tokenizer
e0733cf 
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Gobot1234
Gobot1234 reviewed Jul 22, 2023
View reviewed changes
Comment thread Lib/keyword.py
lysnikolaou
lysnikolaou approved these changes Jul 25, 2023
View reviewed changes

@lysnikolaou lysnikolaou left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after @Gobot1234's comment has been addressed! Great improvement! 🚀

lysnikolaou
lysnikolaou requested changes Jul 25, 2023
View reviewed changes

@lysnikolaou lysnikolaou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see all the test failures. Most of them are about grammar errors or tests about using async/await as soft keywords. @pablogsal Would you like me to take a deeper look into them?

@bedevere-bot

bedevere-bot commented Jul 25, 2023

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@pablogsal
pablogsal requested a review from JelleZijlstra as a code owner July 25, 2023 15:40
@pablogsal

pablogsal commented Jul 25, 2023

Copy link
Copy Markdown
Member Author

@lysnikolaou I have updated the tests in a separate commit. Please, review again

@pablogsal
pablogsal requested a review from lysnikolaou July 25, 2023 15:40
@pablogsal

pablogsal commented Jul 25, 2023

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Jul 25, 2023

Copy link
Copy Markdown

Thanks for making the requested changes!

@lysnikolaou: please review the changes made to this pull request.

@lysnikolaou

lysnikolaou commented Jul 25, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Changes to the tests look good. Let's wait for all the tests to pass and merge! Thanks!

AlexWaygood
AlexWaygood reviewed Jul 25, 2023
View reviewed changes
Comment thread Doc/library/token.rst
@pablogsal
pablogsal merged commit da8f87b into python:main Jul 26, 2023
@pablogsal
pablogsal deleted the gh-107015 branch July 26, 2023 15:34
jtcave pushed a commit to jtcave/cpython that referenced this pull request Jul 27, 2023
@pablogsal @jtcave
pythongh-107015: Remove async_hacks from the tokenizer (python#107018)
0c58adf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood left review comments
@lysnikolaou lysnikolaou lysnikolaou approved these changes
@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner
+1 more reviewer
@Gobot1234 Gobot1234 Gobot1234 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pablogsal @bedevere-bot @lysnikolaou @Gobot1234 @AlexWaygood