gh-106300: Improve assertRaises(Exception) usage in test_runner
#106737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
approved these changes
Aug 16, 2023
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
On one hand, most of these changes are not necessary, because exceptions are differentiated by their messages.
On other hand, a bug similar to the bug in doClassCleanups() testing may occur again, and a custom exception will help catch it.
LGTM. Thank you.
serhiy-storchaka
added
needs backport to 3.11
Contributor
|
Thanks @sobolevn for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
GH-108006 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 16, 2023
…ythonGH-106737) Use a custom exception to prevent unintentional silence of actual errors. (cherry picked from commit fd9d70a) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
|
GH-108007 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 16, 2023
…ythonGH-106737) Use a custom exception to prevent unintentional silence of actual errors. (cherry picked from commit fd9d70a) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
serhiy-storchaka
pushed a commit
that referenced
this pull request
Aug 16, 2023
…GH-106737) (GH-108007) Use a custom exception to prevent unintentional silence of actual errors. (cherry picked from commit fd9d70a) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Yhg1s
pushed a commit
that referenced
this pull request
Aug 16, 2023
…GH-106737) (#108006) gh-106300: Improve errors testing in test_unittest.test_runner (GH-106737) Use a custom exception to prevent unintentional silence of actual errors. (cherry picked from commit fd9d70a) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explaining changes:
raise Exceptionto raise our newCustomError, so we can use it withself.assertRaises(CustomError)CustomErrorReprhelper, so it would work for two styles of test execution (direct and viaregtest):assertRaises(Regex)?(Exception)is problematic #106300 (comment) NowTestableTest.doClassCleanups()is not expected to raise any exceptions :)assertRaises(Regex)?(Exception)is problematic #106300