Doc: Add missing ref labels to exception groups/notes sections#106465
Merged
hugovk merged 2 commits intopython:mainfrom Jul 6, 2023
Merged
Doc: Add missing ref labels to exception groups/notes sections#106465hugovk merged 2 commits intopython:mainfrom
hugovk merged 2 commits intopython:mainfrom
Conversation
CAM-Gerlach
added
docs
Contributor
|
Thanks @CAM-Gerlach for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 6, 2023
…nGH-106465) (cherry picked from commit 38aa89a) Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
|
GH-106473 is a backport of this pull request to the 3.12 branch. |
|
GH-106474 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 6, 2023
…nGH-106465) (cherry picked from commit 38aa89a) Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
hugovk
pushed a commit
that referenced
this pull request
Jul 6, 2023
…GH-106465) (#106473) Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
hugovk
pushed a commit
that referenced
this pull request
Jul 6, 2023
…GH-106465) (#106474) Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the Exception Groups section of the library reference, and (more troublesomely, and unlike all the others there) the Enriching Exceptions with Notes tutorial sections are both missing ref targets labels, so it is not possible to reliably link them either internally or from other docs, PEPs, sites, etc. In particular, this blocks python/peps#3193 as it is not possible to add the required
canonical-docbanners.This PR fixes that by simply adding the relevant ref target labels accordingly.
📚 Documentation preview 📚: https://cpython-previews--106465.org.readthedocs.build/