Skip to content

bpo-31292: Fixed distutils check --restructuredtext for include directives#10605

Merged
csabella merged 10 commits into
python:masterfrom
flying-sheep:bpo-31292
Mar 27, 2019
Merged

bpo-31292: Fixed distutils check --restructuredtext for include directives#10605
csabella merged 10 commits into
python:masterfrom
flying-sheep:bpo-31292

Conversation

@flying-sheep

@flying-sheep flying-sheep commented Nov 20, 2018

Copy link
Copy Markdown
Contributor

Comment thread Lib/distutils/command/check.py Outdated
Comment thread Lib/distutils/tests/test_check.py Outdated
Comment thread Lib/distutils/tests/test_check.py Outdated
@vstinner

Copy link
Copy Markdown
Member

I removed the " needs backport to 3.6" label, the 3.6 branch no longer accept bugfixes (only security fixes are accepted): https://devguide.python.org/#status-of-python-branches

Comment thread Lib/distutils/tests/test_check.py Outdated
@flying-sheep

Copy link
Copy Markdown
Contributor Author

The warning that makes the tests fail doesn’t come from my code. IDK how that can be solved.

@ned-deily

Copy link
Copy Markdown
Member

The warning that makes the tests fail doesn’t come from my code.

@flying-sheep: It's coming from your NEWS entry, generated with blurb. You can reproduce in your working directory by:

cd Doc
make venv
make suspicious

To see how the changelog would look, try:

make html

and then open build/html/whatsnew/changelog.html in your browser.
You can either tweak the NEWS entry so it passes the suspicious test or the line can be added to Doc/tools/susp-ignored.csv

@flying-sheep

Copy link
Copy Markdown
Contributor Author

OK, thank you, very helpful!

I’d gladly have added the “full line with context” to the susp-ignored.csv, but that didn’t work. I had to add only .. include ::.

@merwok

merwok commented Jan 13, 2019

Copy link
Copy Markdown
Member

IMO the first option would be better: write the ``include`` directive in the news entry.

@flying-sheep

Copy link
Copy Markdown
Contributor Author

OK! It’s done.

@csabella
csabella merged commit d5a5a33 into python:master Mar 27, 2019
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @flying-sheep for the PR, and @csabella for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.7.
🐍🍒⛏🤖

@bedevere-bot

Copy link
Copy Markdown

GH-12593 is a backport of this pull request to the 3.7 branch.

@bedevere-bot

Copy link
Copy Markdown

GH-12594 is a backport of this pull request to the 2.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 27, 2019
…tives (pythonGH-10605)

(cherry picked from commit d5a5a33)

Co-authored-by: Philipp A <flying-sheep@web.de>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 27, 2019
…tives (pythonGH-10605)

(cherry picked from commit d5a5a33)

Co-authored-by: Philipp A <flying-sheep@web.de>
miss-islington added a commit that referenced this pull request Mar 27, 2019
…tives (GH-10605)

(cherry picked from commit d5a5a33)

Co-authored-by: Philipp A <flying-sheep@web.de>
miss-islington added a commit that referenced this pull request Mar 27, 2019
…tives (GH-10605)

(cherry picked from commit d5a5a33)

Co-authored-by: Philipp A <flying-sheep@web.de>
@flying-sheep
flying-sheep deleted the bpo-31292 branch March 28, 2019 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants