_ctypes callbacks.c uses _Py_COMP_DIAG_IGNORE_DEPR_DECLS #105732
Conversation
Replace #pragma with _Py_COMP_DIAG_PUSH, _Py_COMP_DIAG_IGNORE_DEPR_DECLS and _Py_COMP_DIAG_POP to ease Python maintenance. Also add a comment explaining why callbacks.c ignores a deprecation warning.
ronaldoussoren
left a comment
ronaldoussoren
left a comment
There was a problem hiding this comment.
Patch looks good, but ...
The fallback from ffi_prep_closure_loc to ffi_prep_closure likely is only useful on macOS when using the system installation of libffi. On other platforms we know at compile time whether or not ffi_prep_closure_loc is available.
It might be possible to avoid compiling the ffi_prep_closure variant on other builds, but at first glance this will only result in even more complex preprocessor code. I can look into this in the near future, but that doesn't have to hold up this PR.
|
When you're done making the requested changes, leave the comment: |
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @ronaldoussoren: please review the changes made to this pull request. |
|
Merged, thanks for the review! |
3 participants
Replace #pragma with _Py_COMP_DIAG_PUSH,
_Py_COMP_DIAG_IGNORE_DEPR_DECLS and _Py_COMP_DIAG_POP to ease Python maintenance. Also add a comment explaining why callbacks.c ignores a deprecation warning.