remove unused #includes of pycore_pymem.h #105166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@vstinner am I missing something here, or are these #includes obsolete? |
vstinner
approved these changes
Jun 1, 2023
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM.
@vstinner am I missing something here, or are these #includes obsolete?
I added comment like // _PyMem_IsPtrFreed() to show which function was used. If the code still builds with the and the function is no longer called in these files, you're good :-) It seems like the code was moved or refactored in the meanwhile. Or the include was copied by mistake. I'm not sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.