bpo-35230: dict: Remove some macros#10513
Merged
methane merged 3 commits intopython:masterfrom Nov 14, 2018
Merged
Conversation
vstinner
reviewed
Nov 13, 2018
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
I dislike "bpo-35230: Remove _Py_REF_DEBUG_COMMA" title, IMHO the main change is that PyDictKeys incref/decref macros are converted to static inline functions. The removal of _Py_REF_DEBUG_COMMA is more a side effect. Even if I know that your goal was to remove _Py_REF_DEBUG_COMMA :-)
vstinner
reviewed
Nov 13, 2018
methane
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
_Py_REF_DEBUG_COMMA,DK_DEBUG_INCREF, andDK_DEBUG_DECREF.Convert
DK_INCREFandDK_DECREFto static inline functions.https://bugs.python.org/issue35230