Skip to content

gh-105102: fix nested unions in structures when the system byteorder is the opposite#105106

Merged
serhiy-storchaka merged 6 commits into
python:mainfrom
Sh3idan:fix-gh-105102
Jan 17, 2024
Merged

gh-105102: fix nested unions in structures when the system byteorder is the opposite#105106
serhiy-storchaka merged 6 commits into
python:mainfrom
Sh3idan:fix-gh-105102

Conversation

@Sh3idan

@Sh3idan Sh3idan commented May 30, 2023

Copy link
Copy Markdown
Contributor

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) January 17, 2024 18:03
@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jan 17, 2024
@serhiy-storchaka
serhiy-storchaka merged commit 0b541f6 into python:main Jan 17, 2024
@miss-islington-app

Copy link
Copy Markdown

Thanks @Sh3idan for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app

Copy link
Copy Markdown

Sorry, @Sh3idan and @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 0b541f64c472976b2fee1ec9919bc7b02a798242 3.12

@miss-islington-app

Copy link
Copy Markdown

Sorry, @Sh3idan and @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 0b541f64c472976b2fee1ec9919bc7b02a798242 3.11

serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Jan 17, 2024
…em byteorder is the opposite (pythonGH-105106)

(cherry picked from commit 0b541f6)

Co-authored-by: Sheidan <37596668+Sh3idan@users.noreply.github.com>
@bedevere-app

bedevere-app Bot commented Jan 17, 2024

Copy link
Copy Markdown

GH-114204 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jan 17, 2024
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Jan 17, 2024
…em byteorder is the opposite (pythonGH-105106)

(cherry picked from commit 0b541f6)

Co-authored-by: Sheidan <37596668+Sh3idan@users.noreply.github.com>
@bedevere-app

bedevere-app Bot commented Jan 17, 2024

Copy link
Copy Markdown

GH-114205 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Jan 17, 2024
serhiy-storchaka added a commit that referenced this pull request Jan 17, 2024
…eorder is the opposite (GH-105106) (GH-114205)

(cherry picked from commit 0b541f6)

Co-authored-by: Sheidan <37596668+Sh3idan@users.noreply.github.com>
serhiy-storchaka added a commit that referenced this pull request Jan 17, 2024
…eorder is the opposite (GH-105106) (GH-114204)

(cherry picked from commit 0b541f6)

Co-authored-by: Sheidan <37596668+Sh3idan@users.noreply.github.com>
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@serhiy-storchaka serhiy-storchaka removed their assignment Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants