Skip to content

gh-62948: IOBase finalizer logs close() exceptions #105104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 3 commits into from
May 31, 2023
Merged

gh-62948: IOBase finalizer logs close() exceptions #105104

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d51cc9
gh-62948: IOBase finalizer logs close() exceptions
vstinner May 30, 2023
b840a37
Update _pyio
vstinner May 30, 2023
533d60d
sys.unraisablehook, not sys.excepthook
vstinner May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
sys.unraisablehook, not sys.excepthook
  • Loading branch information
@vstinner
vstinner committed May 31, 2023
commit 533d60da5c5d9a8b47d90c0d25860208600d20b3
2 changes: 1 addition & 1 deletion Doc/whatsnew/3.13.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ io
--

The :class:`io.IOBase` finalizer now logs the ``close()`` method errors with
:data:`sys.excepthook`. Previously, errors were ignored silently by default,
:data:`sys.unraisablehook`. Previously, errors were ignored silently by default,
and only logged in :ref:`Python Development Mode <devmode>` or on :ref:`Python
built on debug mode <debug-build>`.
(Contributed by Victor Stinner in :gh:`62948`.)
Expand Down
3 changes: 2 additions & 1 deletion Lib/_pyio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,8 @@ def __del__(self):
if closed:
return

# Calling close() can fail: log an unraisable exception
# If close() fails, the caller logs the exception with
# sys.unraisablehook. close() must be called at the end at __del__().
self.close()

### Inquiries ###
Expand Down
2 changes: 1 addition & 1 deletion Misc/NEWS.d/next/Library/2023-05-30-18-45-02.gh-issue-62948.1-5wMR.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
The :class:`io.IOBase` finalizer now logs the ``close()`` method errors with
:data:`sys.excepthook`. Previously, errors were ignored silently by default,
:data:`sys.unraisablehook`. Previously, errors were ignored silently by default,
and only logged in :ref:`Python Development Mode <devmode>` or on
:ref:`Python built on debug mode <debug-build>`. Patch by Victor Stinner.