gh-104786: Remove kwargs-based TypedDict creation#104891
Merged
AlexWaygood merged 10 commits intopython:mainfrom May 25, 2023
Merged
gh-104786: Remove kwargs-based TypedDict creation#104891AlexWaygood merged 10 commits intopython:mainfrom
AlexWaygood merged 10 commits intopython:mainfrom
Conversation
tomasr8
requested review from
AlexWaygood,
Fidget-Spinner,
JelleZijlstra and
gvanrossum
as code owners
AlexWaygood
reviewed
May 24, 2023
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
Looks pretty good! Could you also add a note to https://github.com/python/cpython/blob/main/Doc/whatsnew/3.13.rst#removed?
Member
I would remove the existing .. versionchanged:: 3.13
Removed support for the keyword-argument method of creating ``TypeDict``\s. |
AlexWaygood
reviewed
May 24, 2023
AlexWaygood
reviewed
May 24, 2023
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
reviewed
May 24, 2023
AlexWaygood
reviewed
May 25, 2023
AlexWaygood
reviewed
May 25, 2023
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
reviewed
May 25, 2023
AlexWaygood
approved these changes
May 25, 2023
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
Looks great to me. Thanks @tomasr8!
JelleZijlstra
approved these changes
May 25, 2023
Member
Author
|
Thanks for the reviews! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if/how I should update the docs:
cpython/Doc/library/typing.rst
Lines 1783 to 1785 in c90a862