gh-104873: Add typing.get_protocol_members and typing.is_protocol#104878
Merged
JelleZijlstra merged 14 commits intopython:mainfrom Jun 14, 2023
Merged
gh-104873: Add typing.get_protocol_members and typing.is_protocol#104878JelleZijlstra merged 14 commits intopython:mainfrom
JelleZijlstra merged 14 commits intopython:mainfrom
Conversation
JelleZijlstra
requested review from
AlexWaygood,
Fidget-Spinner and
gvanrossum
as code owners
AlexWaygood
requested changes
May 24, 2023
|
When you're done making the requested changes, leave the comment: |
JelleZijlstra
changed the title
Member
Author
|
I didn't expect the Spanish inquisition! |
|
Nobody expects the Spanish Inquisition! @AlexWaygood: please review the changes made to this pull request. |
AlexWaygood
reviewed
May 24, 2023
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
reviewed
Jun 5, 2023
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
reviewed
Jun 5, 2023
AlexWaygood
reviewed
Jun 5, 2023
AlexWaygood
approved these changes
Jun 5, 2023
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
LGTM, but I'd love to get a third opinion from @gvanrossum or @Fidget-Spinner on the API, if possible
Member
Author
|
FYI I also just emailed typing-sig about this to ask for feedback. |
Member
Author
|
Nobody spoke up against this on typing-sig, time to merge? |
AlexWaygood
reviewed
Jun 13, 2023
AlexWaygood
reviewed
Jun 13, 2023
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
approved these changes
Jun 14, 2023
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
Time to merge, in my opinion!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typing.get_protocol_membersandtyping.is_protocol#104873📚 Documentation preview 📚: https://cpython-previews--104878.org.readthedocs.build/