Skip to content

GH-89812: Add pathlib._PurePathExt #104810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
barneygale wants to merge 20 commits into from
+75 −50
Closed

GH-89812: Add pathlib._PurePathExt #104810

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
81e301b
GH-89812: Add `pathlib._LexicalPath`
barneygale May 23, 2023
ace5824
Rename `_LexicalPath` --> `_BasePurePath`
barneygale May 23, 2023
d1b23c8
Document __bytes__ in PurePath docstring
barneygale May 24, 2023
115002a
Apply suggestions from code review
barneygale May 24, 2023
f257e48
Revert "Document __bytes__ in PurePath docstring"
barneygale May 24, 2023
68d2891
Update Lib/pathlib.py
barneygale May 24, 2023
458c33d
Subclass from `os.PathLike`
barneygale May 24, 2023
6d9a1a2
Add news blurb
barneygale May 24, 2023
bd23782
Revert "Subclass from `os.PathLike`"
barneygale May 24, 2023
a69417f
Revert "Add news blurb"
barneygale May 24, 2023
45f6bd3
Merge branch 'main' into gh-89812-add-lexicalpath
barneygale May 25, 2023
1e24f80
Merge branch 'main' into gh-89812-add-lexicalpath
barneygale May 29, 2023
70d81d6
Merge branch 'main' into gh-89812-add-lexicalpath
barneygale Jun 12, 2023
7e7b5d4
Merge branch 'main' into gh-89812-add-lexicalpath
barneygale Jun 14, 2023
98e30d4
Fix missed isinstance() call.
barneygale Jun 14, 2023
8d12e06
Merge branch 'main' into gh-89812-add-lexicalpath
barneygale Jun 15, 2023
e36eb74
Drop methods from `PurePath` itself, as it cannot be instantiated.
barneygale Jun 22, 2023
0ea24cc
Move as_uri() back
barneygale Jun 23, 2023
342e64b
Adjust docs
barneygale Jun 23, 2023
90bc6b3
Add tests
barneygale Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Document __bytes__ in PurePath docstring
  • Loading branch information
@barneygale
barneygale committed May 24, 2023
commit d1b23c88334136b70e2c12476ff6839fdbc20ee1
5 changes: 5 additions & 0 deletions Lib/pathlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -674,6 +674,11 @@ class PurePath(_BasePurePath):
instantiating a PurePath will return either a PurePosixPath or a
PureWindowsPath object. You can also instantiate either of these classes
directly, regardless of your system.

On Posix, calling ``bytes()`` on a path gives the raw filesystem path as
a bytes object, as encoded by ``os.fsencode()``. On Windows, the unicode
form is the canonical representation of fileysstem paths, and so calling
``bytes()`` on a path is not recommended.
"""
__slots__ = ()

Expand Down