Skip to content

dict insertion order is guaranteed since 3.7#10431

Merged
miss-islington merged 1 commit into
python:masterfrom
andresdelfino:patch-1
Nov 11, 2018
Merged

dict insertion order is guaranteed since 3.7#10431
miss-islington merged 1 commit into
python:masterfrom
andresdelfino:patch-1

Conversation

@andresdelfino

Copy link
Copy Markdown
Contributor

No description provided.

@tirkarthi

Copy link
Copy Markdown
Member

I think auto merge is not triggered here since 2 checks fail with issue number and news entry. Maybe adding skip-news and skip-issue labels will help.

@andresdelfino

andresdelfino commented Nov 11, 2018

Copy link
Copy Markdown
Contributor Author

I think auto merge is not triggered here since 2 checks fail with issue number and news entry. Maybe adding skip-news and skip-issue labels will help.

I don't think so, this PR #10098 didn't have those labels and it was automerged.

@tirkarthi

Copy link
Copy Markdown
Member

The linked PR had both an issue number and a NEWS entry so it didn't require those labels and all checks passed. skip label is required when there is no issue in title and adding it makes the check pass and same for skip news. I hope it's the reason auto merge doesn't but I might be wrong.

@andresdelfino

Copy link
Copy Markdown
Contributor Author

The linked PR had both an issue number and a NEWS entry so it didn't require those labels and all checks passed. skip label is required when there is no issue in title and adding it makes the check pass and same for skip news. I hope it's the reason auto merge doesn't but I might be wrong.

I see, sorry 😅

@andresdelfino

andresdelfino commented Nov 11, 2018

Copy link
Copy Markdown
Contributor Author

The linked PR had both an issue number and a NEWS entry so it didn't require those labels and all checks passed. skip label is required when there is no issue in title and adding it makes the check pass and same for skip news. I hope it's the reason auto merge doesn't but I might be wrong.

You are right, reading the source tells miss-islington expects those checks to be successful too:

https://github.com/python/miss-islington/blob/2e69ff6506767bbfa6436585bfdad9d43f888ced/miss_islington/status_change.py#L98

@tirkarthi

Copy link
Copy Markdown
Member

No problem, TIL for me :)

@Mariatta

Copy link
Copy Markdown
Member

Yes, the PR will only be automerge if:

  • all status checks passed,
  • and it's been approved by core dev,
  • and CLA has been signed.

@miss-islington

Copy link
Copy Markdown
Contributor

@andresdelfino: Status check is done, and it's a success ✅ .

@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @andresdelfino for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington

Copy link
Copy Markdown
Contributor

@andresdelfino: Status check is done, and it's a success ✅ .

@bedevere-bot

Copy link
Copy Markdown

GH-10465 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 11, 2018
(cherry picked from commit 76e8fd7)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
@andresdelfino
andresdelfino deleted the patch-1 branch November 11, 2018 16:58
miss-islington added a commit that referenced this pull request Nov 11, 2018
(cherry picked from commit 76e8fd7)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants