gh-104282: Fix null pointer dereference in lzma._decode_filter_properties#104283
Merged
serhiy-storchaka merged 4 commits intoJan 17, 2024
Merged
gh-104282: Fix null pointer dereference in lzma._decode_filter_properties#104283serhiy-storchaka merged 4 commits into
lzma._decode_filter_properties#104283serhiy-storchaka merged 4 commits into
Conversation
* add `options` field NULL checks in `build_filter_spec` for BCJ filters and in `_decode_filter_properties` implementation * add tests
serhiy-storchaka
enabled auto-merge (squash)
January 17, 2024 12:56
serhiy-storchaka
disabled auto-merge
January 17, 2024 12:57
serhiy-storchaka
enabled auto-merge (squash)
January 17, 2024 13:01
lzma._decode_filter_propertieslzma._decode_filter_properties
|
Thanks @chgnrdv for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 17, 2024
…_properties` (pythonGH-104283) (cherry picked from commit 0154405) Co-authored-by: Radislav Chugunov <52372310+chgnrdv@users.noreply.github.com>
|
GH-114181 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 17, 2024
…_properties` (pythonGH-104283) (cherry picked from commit 0154405) Co-authored-by: Radislav Chugunov <52372310+chgnrdv@users.noreply.github.com>
|
GH-114182 is a backport of this pull request to the 3.11 branch. |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Jan 17, 2024
serhiy-storchaka
pushed a commit
that referenced
this pull request
Jan 17, 2024
kulikjak
pushed a commit
to kulikjak/cpython
that referenced
this pull request
Jan 22, 2024
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #104282
lzma._decode_filter_propertiescrashes with BCJ filter and buffer of zero length #104282