Skip to content

gh-104144: Optimize gather to finish eagerly when all futures complete eagerly #104138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 8 commits into from
May 6, 2023
Merged

gh-104144: Optimize gather to finish eagerly when all futures complete eagerly #104138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b3e479a
gh-NNNN: Skip creating GatheringFuture if all futures finished eagerly
itamaro May 3, 2023
8eeebaf
Add NEWS entry
itamaro May 3, 2023
9289c9e
Apply review suggestion to NEWS entry
itamaro May 4, 2023
edbb04c
Merge branch 'main' into asyncio-skip-gathering-future
itamaro May 5, 2023
9be6e51
Modify implementation to eagerly call done callbacks at the end of th…
itamaro May 5, 2023
250b73c
update inline comment and NEWS entry
itamaro May 5, 2023
7df90eb
Merge branch 'main' into asyncio-skip-gathering-future
itamaro May 5, 2023
ce52714
Fix NEWS typo
gvanrossum May 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion Lib/asyncio/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -813,6 +813,7 @@ def _done_callback(fut):
children = []
nfuts = 0
nfinished = 0
done_futs = []
loop = None
outer = None # bpo-46672
for arg in coros_or_futures:
Expand All @@ -829,7 +830,10 @@ def _done_callback(fut):

nfuts += 1
arg_to_fut[arg] = fut
fut.add_done_callback(_done_callback)
if fut.done():
done_futs.append(fut)
else:
fut.add_done_callback(_done_callback)

else:
# There's a duplicate Future object in coros_or_futures.
Expand All @@ -838,6 +842,13 @@ def _done_callback(fut):
children.append(fut)

outer = _GatheringFuture(children, loop=loop)
# Run done callbacks after GatheringFuture created so any post-processing
# can be performed at this point
# optimization: in the special case that *all* futures finished eagerly,
# this will effectively complete the gather eagerly, with the last
# callback setting the result (or exception) on outer before returning it
for fut in done_futs:
_done_callback(fut)
return outer


Expand Down
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Library/2023-05-03-16-50-24.gh-issue-104144.yNkjL8.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Optimize :func:`asyncio.gather` when using :func:`asyncio.eager_task_factory`
to complete eagerly if all fututres completed eagerly.
Avoid scheduling done callbacks for futures that complete eagerly.