Skip to content

gh-103758: ensure previously registered forkers get executed along with new ones #103759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
itsankitkp wants to merge 4 commits into
base: main
Choose a base branch
from
Open

gh-103758: ensure previously registered forkers get executed along with new ones #103759

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
84339c2
ensure previously registered forkers get executed along with new ones
itsankitkp Apr 24, 2023
a803e07
properly exit test case
itsankitkp Apr 24, 2023
e7a00d7
Update Lib/test/test_posix.py
itsankitkp Apr 24, 2023
4f8e1b6
update comments
itsankitkp Apr 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions Lib/test/test_posix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,48 @@ def test_register_at_fork(self):
"""
assert_python_ok('-c', code)

@support.requires_fork()
def test_register_at_fork_multiple_runs(self):
# if we run fork multiple times, previously registered
# callbacks should get executed along with newly registered
code = """if 1:
import os

r, w = os.pipe()
fin_r, fin_w = os.pipe()
# register all forkers
os.register_at_fork(before=lambda: os.write(w, b'A'))
os.register_at_fork(after_in_parent=lambda: os.write(w, b'B'))
os.register_at_fork(after_in_child=lambda: os.write(w, b'C'))

pid = os.fork()
if pid == 0:
# register new forkers
os.register_at_fork(before=lambda: os.write(w, b'D'))
os.register_at_fork(after_in_parent=lambda: os.write(w, b'E'))
os.register_at_fork(after_in_child=lambda: os.write(w, b'F'))
child_pid = os.fork()
if child_pid == 0:
os.close(w)
os.read(fin_r, 1)
os._exit(0)
os.close(w)
os.read(fin_r, 1)
os.write(fin_w, b'!')
os._exit(0)
else:
os.close(w)
try:
with open(r, "rb") as f:
data = f.read()
assert len(data) == 9, data
# Check return values of all callbacks
assert data == b'ABCDABECF', data
finally:
os.write(fin_w, b'!')
"""
assert_python_ok('-c', code)

@unittest.skipUnless(hasattr(posix, 'lockf'), "test needs posix.lockf()")
def test_lockf(self):
fd = os.open(os_helper.TESTFN, os.O_WRONLY | os.O_CREAT)
Expand Down