bpo-33578: Fix getstate/setstate for CJK decoder#10290
Merged
Merged
Conversation
Previous version was casting to Py_ssize_t incorrectly and exhibited unexpected behaviour on big endian systems.
libcthorne
force-pushed
the
fix-cjk-decoder-state
branch
from
November 2, 2018 00:56
532df04 to
3b2cca8
Compare
methane
approved these changes
Nov 2, 2018
Member
|
Thanks for quick fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous version (#6984) was casting to
Py_ssize_tincorrectly and exhibited unexpected behaviour on big endian systems.https://bugs.python.org/issue33578