[Skip Issue] Fix a possible crash due to range_reverse()#10252
Merged
Conversation
serhiy-storchaka
approved these changes
Oct 31, 2018
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
There was an assumption that PyObject_New() fills memory with zeros. Some of object-creating methods do this, but not in this case.
Contributor
|
Thanks @ZackerySpytz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 31, 2018
(cherry picked from commit c9a6168) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
|
GH-10256 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 31, 2018
(cherry picked from commit c9a6168) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
|
GH-10257 is a backport of this pull request to the 3.6 branch. |
miss-islington
added a commit
that referenced
this pull request
Oct 31, 2018
(cherry picked from commit c9a6168) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Oct 31, 2018
(cherry picked from commit c9a6168) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If any of the
PyNumber_*calls fail while the new iterator object is being prepared, a crash will occur during deallocation.