Skip to content

[3.11] gh-85747: Active voice & suggested edits, 'running/stopping loop' & 'callbacks' subsections of asyncio-eventloop.rst (GH-100270) #102006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gvanrossum merged 2 commits into from
Feb 18, 2023
Merged

[3.11] gh-85747: Active voice & suggested edits, 'running/stopping loop' & 'callbacks' subsections of asyncio-eventloop.rst (GH-100270) #102006

gvanrossum merged 2 commits into from
Feb 18, 2023

Conversation

@bskinn
Copy link
Contributor

@bskinn bskinn commented Feb 17, 2023

[3.11] gh-85747: Active voice & suggested edits, 'running/stopping loop' & 'callbacks' subsections of asyncio-eventloop.rst (GH-100270)

Co-authored-by: C.A.M. Gerlach CAM.Gerlach@Gerlach.CAM
Co-authored-by: Terry Jan Reedy tjreedy@udel.edu
(cherry picked from commit c4de6b1)

@bskinn
[3.11] gh-85747: Active voice & suggested edits, 'running/stopping lo…
0026ac7 
…op' & 'callbacks' subsections of asyncio-eventloop.rst (GH-100270)

Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>.
(cherry picked from commit c4de6b1)

Co-authored-by: Brian Skinn <brian.skinn@gmail.com>
@bskinn bskinn requested review from 1st1 and asvetlov as code owners February 17, 2023 22:32
This was referenced Feb 17, 2023
Closed
Merged
@bedevere-bot bedevere-bot added skip news docs Documentation in the Doc dir labels Feb 17, 2023
gvanrossum
gvanrossum requested changes Feb 18, 2023
View reviewed changes
@bedevere-bot
Copy link

bedevere-bot commented Feb 18, 2023

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@bskinn
Remove timeout description
bdace8b 
The `timeout` parameter was not added until 3.12.
@gvanrossum gvanrossum merged commit 5220c2d into python:3.11 Feb 18, 2023
@bskinn bskinn deleted the backport-c4de6b1-3.11 branch February 18, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bskinn @bedevere-bot @gvanrossum