bpo-22021: shutil.make_archive() root_dir do not work#10191
bpo-22021: shutil.make_archive() root_dir do not work#10191nanjekyejoannah wants to merge 1 commit intopython:masterfrom nanjekyejoannah:fix-issue-22021
Conversation
Signed-off-by: nanjekyejoannah <nanjekyejoannah@gmail.com>
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
|
@nanjekyejoannah: Hum, it seems like test_shutil is failing. Can you try to investigate why it fails? (tell me if you need help) |
|
Can you please amend your commit message to mention the original author? Example: About your commit message: The first line is useless: the bpo number is already part of the commit title. On the second line, |
|
@vstinner I sign the commits just incase it is a requirement as most projects I have opened PRs on require. I think am too used also :) Review noted. I will revert with fixes for the same. |
|
The current behavior looks correct to me. It is consistent with the behavior of the Read the discussion on bpo-22021. |
This PR fixes issue : https://bugs.python.org/issue22021.
Signed-off-by: nanjekyejoannah <nanjekyejoannah@gmail.com
https://bugs.python.org/issue22021