Skip to content

gh-101860: Expose __name__ on property #101876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 4 commits into from
Feb 20, 2024
Merged

gh-101860: Expose __name__ on property #101876

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8ec1251
gh-101860: Expose __name__ on property
eltoder Feb 13, 2023
e514472
Fallback to `func.__name__` if property `__name__` not set.
eltoder Feb 17, 2024
5dfa4f4
Merge branch 'main' into feature/property-name
eltoder Feb 17, 2024
c20e9a7
Fallback to `fget.__name__` if name is not set
eltoder Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fallback to func.__name__ if property __name__ not set.
  • Loading branch information
@eltoder
eltoder committed Feb 17, 2024
commit e5144729ba867d46fa83472d5b50bb0bd6eb2a73
5 changes: 3 additions & 2 deletions Lib/inspect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -834,8 +834,9 @@ def _finddoc(obj):
cls = self.__class__
# Should be tested before isdatadescriptor().
elif isinstance(obj, property):
name = obj.__name__
cls = _findclass(obj.fget)
func = obj.fget
name = obj.__name__ or func.__name__
cls = _findclass(func)
if cls is None or getattr(cls, name) is not obj:
return None
elif ismethoddescriptor(obj) or isdatadescriptor(obj):
Expand Down
5 changes: 3 additions & 2 deletions Lib/pydoc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,9 @@ def _finddoc(obj):
cls = self.__class__
# Should be tested before isdatadescriptor().
elif isinstance(obj, property):
name = obj.__name__
cls = _findclass(obj.fget)
func = obj.fget
name = obj.__name__ or func.__name__
cls = _findclass(func)
if cls is None or getattr(cls, name) is not obj:
return None
elif inspect.ismethoddescriptor(obj) or inspect.isdatadescriptor(obj):
Expand Down