Skip to content

bpo-35064 prefix smelly symbols that appear with COUNT_ALLOCS with _Py_#10152

Merged
pablogsal merged 1 commit into
python:masterfrom
pablogsal:bpo35064
Oct 28, 2018
Merged

bpo-35064 prefix smelly symbols that appear with COUNT_ALLOCS with _Py_#10152
pablogsal merged 1 commit into
python:masterfrom
pablogsal:bpo35064

Conversation

@pablogsal

@pablogsal pablogsal commented Oct 27, 2018

Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if "make smelly" no longer fails when COUNT_ALLOCS is defined.

I suggest to only fix master. The bug is here for years and nobody complained.

Just be carefull in the typo in the PR title.

@pablogsal pablogsal changed the title bpo-35064 prefix semelly symbols that appear with COUNT_ALLOCS with _Py_ bpo-35064 prefix smelly symbols that appear with COUNT_ALLOCS with _Py_ Oct 28, 2018
@pablogsal
pablogsal merged commit 49c75a8 into python:master Oct 28, 2018
@pablogsal
pablogsal deleted the bpo35064 branch October 28, 2018 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants