bpo-32173: linecache.py add lazycache to __all__ and use dict.clear to clear the cache #10130
Closed
srinivasreddy wants to merge 2 commits into
Closed
bpo-32173: linecache.py add lazycache to __all__ and use dict.clear to clear the cache #10130srinivasreddy wants to merge 2 commits into
srinivasreddy wants to merge 2 commits into
Conversation
Contributor
Author
|
Mariatta was mentioned, but she's out of open source for the rest of September 2018, and parts of October 2018 . Be aware she might not get to this until November 2018. |
akuchling
approved these changes
Mar 21, 2020
akuchling
left a comment
akuchling
left a comment
Contributor
There was a problem hiding this comment.
This refactoring looks like a pleasant clean-up for the code. I don't think it needs any additions to the test suite, so I don't think any further work is needed.
Contributor
|
On looking like the conflict, it looks like someone has already applied basically the same changes from PR-4641. So I'll just close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue32173