gh-101152: Implement PEP 699#101193
Merged
Fidget-Spinner merged 16 commits intopython:mainfrom Jan 24, 2023
Merged
Conversation
Member
|
Contributor
Author
added the news and infact it is a replica of his solution |
Misc/NEWS.d/next/Build/2023-01-21-10-31-35.gh-issue-101152.xvM8pL.rst
Outdated
Show resolved
Hide resolved
Member
Fidget-Spinner
left a comment
Fidget-Spinner
left a comment
There was a problem hiding this comment.
Just some feedback for your future contributions:
- You can close conversations. Click on the "resolve conversation" button once you feel that you resolved the comment.
- reStructuredText markup is a little tricky! So you can refer to the devguide for that https://devguide.python.org/documentation/markup/
- I'll try to summarise what I look for in the Whats New deprecation. First you want to know exactly what is being affected (in this case the field of a certain struct being deprecated). Secondly, you want to know, without ambiguity, how we will notify users of this deprecation. In this case it's a compiler warning. Lastly, if there's a planned removal version for the deprecated thing, it should be mentioned too.
Thank you.
Misc/NEWS.d/next/Build/2023-01-21-10-31-35.gh-issue-101152.xvM8pL.rst
Outdated
Show resolved
Hide resolved
Fidget-Spinner
changed the title
Co-authored-by: Ken Jin <kenjin@python.org>
…8pL.rst Co-authored-by: Ken Jin <kenjin@python.org>
Contributor
Author
The feedback was very helpful, will surely keep the points in mind. Thanks |
Co-authored-by: Ken Jin <kenjin@python.org>
Member
|
Can you rebase with main and fix the conflicts in 3.12 whats new please? Seems like someone wrote an entry at the current spot. |
Contributor
Author
yes sure |
Fidget-Spinner
approved these changes
Jan 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gh-101152: Added the PEP 699 Implementation