Repository navigation
gh-100687: Reduce frequency of overallocation in long_add #100688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
06c0bb6
Adjust x_add so that it overallocates much less often
mdickinson 9782b45
Revert unrelated change
mdickinson 893f9d6
News entry
mdickinson 247df54
add test for long addition with over allocation
eendebakpt 8d6bd2a
Double check that extra_digit is always true when we we've got a carry
mdickinson deb64d9
Merge pull request #3 from eendebakpt/leaner-long-add-test
mdickinson 237afe8
Merge remote-tracking branch 'upstream/main' into leaner-long-add
mdickinson e159e2e
Update Misc/NEWS entry to acknowledge contributions
mdickinson 5d97741
Always set a value for the extra digit
mdickinson c3002e2
Set digit count correctly
mdickinson db81b71
Style tweaks
mdickinson 9955db2
Merge in the main branch
encukou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
Misc/NEWS.d/next/Core and Builtins/2023-01-02-14-54-12.gh-issue-100688.yenIag.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Reduce frequency of overallocation in some cases of multidigit integer | ||
| additions and subtractions. Thanks Pieter Eendebak for contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can fire for
a = 1 + (1 << (30*70)); b = 1 << (30*139); a*b. The multiplication is via karatsuba which has some internal calls that end up here.Note: I am revisiting this PR because it helps with a freelist for 2-, and 3-digit ints. Without this PR additions allocate for n digits (via the freelist), normalize to n-1 digits and on free push the n-1 bucket of the freelist.