add tests for asyncio transport sockets#100263
Merged
Merged
Conversation
kumaraditya303
requested review from
1st1,
asvetlov and
gvanrossum
as code owners
December 15, 2022 11:11
gvanrossum
reviewed
Dec 22, 2022
gvanrossum
left a comment
gvanrossum
left a comment
Member
There was a problem hiding this comment.
If the answers to my questions are "that's just how it is for listening sockets" or something like that, why bother to verify the OS behavior?
gvanrossum
approved these changes
Dec 27, 2022
gvanrossum
left a comment
gvanrossum
left a comment
Member
There was a problem hiding this comment.
LG, add the requested comment and land it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.