Skip to content

gh-100131: Add optional delete parameter to tempfile.TemporaryDirectory()#100132

Merged
gpshead merged 9 commits into
python:mainfrom
JakobDev:tempdelete
Mar 24, 2023
Merged

gh-100131: Add optional delete parameter to tempfile.TemporaryDirectory()#100132
gpshead merged 9 commits into
python:mainfrom
JakobDev:tempdelete

Conversation

@JakobDev

@JakobDev JakobDev commented Dec 9, 2022

Copy link
Copy Markdown
Contributor

@netlify

netlify Bot commented Dec 9, 2022

Copy link
Copy Markdown

Deploy Preview for python-cpython-preview canceled.

Name Link
🔨 Latest commit 31a4966
🔍 Latest deploy log https://app.netlify.com/sites/python-cpython-preview/deploys/63931a5ed081210008e5461a

@bedevere-bot

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@ghost

ghost commented Dec 9, 2022

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@zware zware left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch @JakobDev! This looks good, but incomplete: we'll need to add tests and documentation for this change.

@JakobDev

Copy link
Copy Markdown
Contributor Author

test and documentation have now been added

@arhadthedev
arhadthedev requested a review from zware March 22, 2023 11:36
@gpshead

gpshead commented Mar 23, 2023

Copy link
Copy Markdown
Member

Closing per the discussion on the issue as we don't need this.

@gpshead gpshead closed this Mar 23, 2023
@AlexWaygood

This comment was marked as duplicate.

@gpshead gpshead reopened this Mar 24, 2023
@gpshead gpshead self-assigned this Mar 24, 2023
@gpshead
gpshead merged commit 64cb1a4 into python:main Mar 24, 2023
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request Mar 27, 2023
…irectory() (python#100132)

Add optional delete parameter to tempfile.TemporaryDirectory().

Co-authored-by: Gregory P. Smith <greg@krypto.org>
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
…irectory() (python#100132)

Add optional delete parameter to tempfile.TemporaryDirectory().

Co-authored-by: Gregory P. Smith <greg@krypto.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants