gh-100110: Specialize FOR_ITER for tuples#100109
Merged
Merged
Conversation
✅ Deploy Preview for python-cpython-preview canceled.
|
Fidget-Spinner
changed the title
Member
|
I'm not sure that I entirely trust those stats, yet. |
markshannon
approved these changes
Dec 8, 2022
markshannon
left a comment
markshannon
left a comment
Member
There was a problem hiding this comment.
Looks good.
Have you attempted to benchmark this?
Member
Author
No. It's just one specialisation. I doubt anything in pyperformance will change. |
Member
|
I'm running the stats on it. |
Member
|
The stats show what I would expect. No specialization failures for tuples, and an increase of hit rates for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as FOR_ITER_LIST, but it accounts for 57% of our current failures.
https://github.com/faster-cpython/ideas/blob/main/stats/pystats-python-a87c46e-2022-12-04.md#specialization-attempts-3