Skip to content

gh-99955: standardize return values of functions in compiler's code-gen - #100010

Merged
iritkatriel merged 96 commits into
python:mainfrom
iritkatriel:return_values
Dec 12, 2022
Merged

iritkatriel merged 96 commits into
python:mainfrom
iritkatriel:return_values

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Dec 5, 2022 •

Copy link
Copy Markdown
Member

Consistently return -1 for error, 0 for success.

@iritkatriel iritkatriel added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 5, 2022
@bedevere-bot

ghost commented Dec 5, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 730f5fd 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 5, 2022
Comment thread Python/compile.c Resolved
@markshannon
markshannon self-requested a review December 12, 2022 10:14

ghost left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. This makes the code so much easier to follow and maintain.

@markshannon

ghost commented Dec 12, 2022

Copy link
Copy Markdown
Member

Actually, it is probably best to add a news item, so anyone familiar with the code knows about the change.

@netlify

ghost commented Dec 12, 2022 •

Copy link
Copy Markdown

✅ Deploy Preview for python-cpython-preview canceled.

Name Link
🔨 Latest commit a47b482
🔍 Latest deploy log https://app.netlify.com/sites/python-cpython-preview/deploys/6397275b1af5c3000881e0e0

Comment thread Python/compile.c Resolved
Irit Katriel and others added 3 commits December 12, 2022 11:31
Comment thread Python/compile.c Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants