You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
selector_events.BaseSelectorEventLoop.sock_connect should preserve socket type #77859
The current behavior causes an exception to be raised when trying to create a datagram socket and _ipaddr_info returns None (since asyncio then calls loop.getaddrinfo with SOCK_STREAM and IPPROTO_UDP).
Preserving socket type is made difficult by https://bugs.python.org/issue21327; the proposed patch includes a dirty workaround. I do not know yet if it works on Windows.
--- selector_events.py 2018-05-11 10:01:42.011164837 +0800+++ selector_events.py.new 2018-05-29 17:41:03.103155480 +0800@@ -439,8 +439,9 @@
raise ValueError("the socket must be non-blocking")
if not hasattr(socket, 'AF_UNIX') or sock.family != socket.AF_UNIX:
+ socktype = sock.type & 0xf # WA https://bugs.python.org/issue21327
resolved = base_events._ensure_resolved(
- address, family=sock.family, proto=sock.proto, loop=self)+ address, family=sock.family, type=socktype, proto=sock.proto, loop=self)
if not resolved.done():
yield from resolved
_, _, _, _, address = resolved.result()[0]
This error seems to come from base_events.py, lines 142-145, and since it's an OS specific limitation, I can't see Sebastien's suggestion as a feasible solution.
Maybe we could come up with something along the lines of the following patch. What do you think about it?
diff --git a/Lib/asyncio/base_events.py b/Lib/asyncio/base_events.py
index 3726c556d4..15ee4d9d1b 100644
--- a/Lib/asyncio/base_events.py+++ b/Lib/asyncio/base_events.py@@ -142,6 +142,9 @@ def _ipaddr_info(host, port, family, type, proto):
if '%' in host:
# Linux's inet_pton doesn't accept an IPv6 zone index after host,
# like '::1%lo0'.
+ if sys.platform.startswith('linux'):+ return OSError("Linux's inet_pton doesn't accept an IPv6 "+ "zone index after host")
return None
for af in afs:
diff --git a/Lib/test/test_asyncio/test_base_events.py b/Lib/test/test_asyncio/test_base_events.py
index 6d544d1eda..1b944ff89e 100644
--- a/Lib/test/test_asyncio/test_base_events.py+++ b/Lib/test/test_asyncio/test_base_events.py@@ -109,6 +109,9 @@ class BaseEventTests(test_utils.TestCase):
self.assertIsNone(
base_events._ipaddr_info('::3', 1, INET, STREAM, TCP))
+ @unittest.skipIf(sys.platform.startswith('linux'),+ "Linux's inet_pton doesn't accept an IPv6 zone index after host")+ def test_for(self):
# IPv6 address with zone index.
self.assertIsNone(
base_events._ipaddr_info('::3%lo0', 1, INET6, STREAM, TCP))
twisteroidambassador commented on Dec 24, 2018
twisteroidambassadormannequin
Mannequin
More actions
Looks like this bug is also cause by using _ensure_resolved() more than once for a given host+port, so it can probably be fixed together with https://bugs.python.org/issue35545 .
Activity
sebastienbourdeauducq commentedon May 29, 2018
The current behavior causes an exception to be raised when trying to create a datagram socket and _ipaddr_info returns None (since asyncio then calls loop.getaddrinfo with SOCK_STREAM and IPPROTO_UDP).
Preserving socket type is made difficult by https://bugs.python.org/issue21327; the proposed patch includes a dirty workaround. I do not know yet if it works on Windows.
sebastienbourdeauducq commentedon May 29, 2018
Windows looks fine.
1st1 commentedon May 29, 2018
Can you write a unittest that exposes the bug?
apatrushev commentedon Jul 26, 2018
I created small script showing the error.
augustogoulart commentedon Nov 7, 2018
This error seems to come from base_events.py, lines 142-145, and since it's an OS specific limitation, I can't see Sebastien's suggestion as a feasible solution.
Maybe we could come up with something along the lines of the following patch. What do you think about it?
twisteroidambassador commentedon Dec 24, 2018
Looks like this bug is also cause by using _ensure_resolved() more than once for a given host+port, so it can probably be fixed together with https://bugs.python.org/issue35545 .
Masking sock.type should not be necessary anymore since https://bugs.python.org/issue32331 fixed it.
csabella commentedon May 26, 2020
For reference, please note the comments in #11403 (comment).
kumaraditya303 commentedon Sep 16, 2026
Fixed by #31499