Repository navigation
Rename 'name' to 'fullname' argument to ExtensionFileLoader #74460
Description
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = None
created_at = <Date 2017-05-04.22:24:49.383>
labels = ['easy', 'type-feature', 'library', '3.11']
title = "Rename 'name' to 'fullname' argument to ExtensionFileLoader"
updated_at = <Date 2021-08-26.19:45:24.698>
user = 'https://github.com/brettcannon'bugs.python.org fields:
activity = <Date 2021-08-26.19:45:24.698>
actor = 'python-dev'
assignee = 'docs@python'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2017-05-04.22:24:49.383>
creator = 'brett.cannon'
dependencies = []
files = []
hgrepos = []
issue_num = 30274
keywords = ['patch', 'easy']
message_count = 6.0
messages = ['293022', '293122', '294193', '339886', '393702', '400363']
nosy_count = 7.0
nosy_names = ['brett.cannon', 'docs@python', 'python-dev', 'sayanchowdhury', 'iritkatriel', 'zkneupper', 'DonnaDia']
pr_nums = ['1735', '26195', '27981']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue30274'
versions = ['Python 3.11']
Activity
brettcannon commentedon May 4, 2017
https://docs.python.org/3/library/importlib.html#importlib.machinery.ExtensionFileLoader says "fullname, path" for __init__(), but
cpython/Lib/importlib/_bootstrap_external.py
Line 909 in 647c3d3
brettcannon commentedon May 5, 2017
Another option is to rename 'name' to 'fullname', make 'name' keyword-only, and then raise a DeprecationWarning if 'name' is used, eventually removing the keyword-only argument.
sayanchowdhury commentedon May 22, 2017
I am starting to work on this issue.
brettcannon commentedon Apr 10, 2019
I realized another solution to this is to make the argument positional-only, then the name simply doesn't matter. Probably unnecessary breakage, though.
iritkatriel commentedon May 14, 2021
The PR was reviewed but it now has merge conflicts and possibly a test failure on MacOS.
[-]Make importlib.abc.ExtensionFileLoader.__init__() documentation match code[/-][+]Rename 'name' to 'fullname' argument to ExtensionFileLoader[/+]DonnaDia commentedon Aug 26, 2021
I want to work on it.
brettcannon commentedon May 4, 2022
This has been like this for so long I don't think it's worth the potential breakage to fix.