shutil should accept pathlib types #67430

Activity

1. mkesper commented on Jan 14, 2015

   

   mkespermannequin

   on Jan 14, 2015

   MannequinAuthor

   More actions

   source_path = Path('../data')
   destination_path = Path('//file_server/work/whatever')
   for file_name in source_path.glob('xyz-*'):
       shutil.copyfile(source_path / file_name, destination_path / file_name)

   leads to:

   Traceback (most recent call last):
     File "copy_shares_2_work.py", line 9, in <module>
       shutil.copyfile(source_path / file_name, destination_path / file_name)
     File "C:\Python34\lib\shutil.py", line 90, in copyfile
       if _samefile(src, dst):
     File "C:\Python34\lib\shutil.py", line 75, in _samefile
       return os.path.samefile(src, dst)
     File "C:\Python34\lib\genericpath.py", line 90, in samefile
       s1 = os.stat(f1)
   TypeError: argument should be string, bytes or integer, not WindowsPath

   Converting to str() works but is unexpected.
2. mkesper

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   on Jan 14, 2015
3. bitdancer commented on Jan 14, 2015

   

   bitdancer

   on Jan 14, 2015

   Member

   More actions

   This is a specific example of a global discussion about handling of paths in the stdlib. So far we have elected not to provide special handling. The correct thing to do is call str. I'm not sure if shutil is special enough to be a special case, but it would need to be discussed in the context of the larger issue in some forum other than the bug tracker (probably python-dev).
4. serhiy-storchaka commented on Mar 26, 2017

   

   serhiy-storchaka

   on Mar 26, 2017

   Member

   More actions

   Is this issue outdated since implementing a file system path protocol (PEP-519) in 3.6?
5. vstinner commented on Mar 27, 2017

   

   vstinner

   on Mar 27, 2017

   Member

   More actions

   I'm unable to reproduce the bug on Python 3.6:
   ---

   from pathlib import Path
   import shutil
   import os
   def touch(name):
       with open(name, "x"):
           pass
   os.mkdir('a')
   touch('a/x')
   touch('a/y')
   touch('a/z')
   os.mkdir('b')
   source_path = Path('a')
   destination_path = Path('b')
   for file_name in source_path.glob('*'):
       file_name = file_name.name
       src = source_path / file_name
       dst = destination_path / file_name
       print("%r -> %r" % (src, dst))
       shutil.copyfile(src, dst)

   ---

   Output:
   ---
   PosixPath('a/y') -> PosixPath('b/y')
   PosixPath('a/x') -> PosixPath('b/x')
   PosixPath('a/z') -> PosixPath('b/z')
   ---

   Thank you PEP-519 ;-)
6. vstinner

   closed this as completedon Mar 27, 2017
7. ezio-melotti

   transferred this issue fromon Apr 10, 2022