You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add Heap (and DynamicHeap) classes to heapq module #62034
heapq already provides a bunch of functions for manipulating lists that preserve (or create) a heap invariant. My change adds two classes for representing heaps. These classes ensure that operations that violate the heap invariant are not possible (through the public interface). The also allow customization via subclassing.
Are you suggesting that I put my new classes in a new module and rename them? I think it'd be better to keep them in heapq, unless someone intended to add more classes to your proposed queue module, because heap functionality would be spread between two modules (heapq and queue).
One could argue that these classes could go in the collections module, but I think sticking to heapq is best.
Serhiy is pointing you to an existing use of heapq in the stdlib. I'm not quite sure what his intent is in pointing it out, though it *might* be to point out that heapq is a primitive, and PriorityQueue already implements a subclassable class using it.
I don't personally have any opinion either way on the utility of your proposed classes. I've only ever used PriorityQueue once :)
allyourcode commented on Apr 25, 2013
allyourcodemannequin
MannequinAuthor
More actions
Ah, Serhiy is pointing out that there's already a class named PriorityQueue in the queue module. I didn't know that exists.
Now that I've had a chance to look at it, queue.PriorityQueue is like my Heap class, but there are some interesting difference; moreover, I'm also proposing DynamicHeap, which is pretty different from PriorityQueue. Perhaps, I should find a way to augment PriorityQueue so that it supports the interesting features of DynamicHeap?
From my multilingual experience I can say that priority queue is very rarely used type of collections (but if it needed it is very usefull). On one hand, Python stdlib already contains one such type, and this type will be good enough in non-performance-critical applications. On other hand, a non-locked implementation using heapq is trivial (just encapsulate a list inside a class), no one will implement it wrong (if do not over-complicate the interface). I don't see the need for yet one priority queue. The presence of two very similar types in the stdlib will lead to confusion.
Daniel, I've already been in the process of adding a class to the heapq module and have done substantial work on it over the last few months. I'll look at your code to see if there are any ideas that should be merged with it before I finish it up.
Am attaching my current draft for Heap(). A PriorityQueue() variant would also be added to 3.4.
Activity
allyourcode commentedon Apr 24, 2013
heapq already provides a bunch of functions for manipulating lists that preserve (or create) a heap invariant. My change adds two classes for representing heaps. These classes ensure that operations that violate the heap invariant are not possible (through the public interface). The also allow customization via subclassing.
serhiy-storchaka commentedon Apr 24, 2013
queue.PriorityQueue?
allyourcode commentedon Apr 24, 2013
Hey Serhiy,
Are you suggesting that I put my new classes in a new module and rename them? I think it'd be better to keep them in heapq, unless someone intended to add more classes to your proposed queue module, because heap functionality would be spread between two modules (heapq and queue).
One could argue that these classes could go in the collections module, but I think sticking to heapq is best.
bitdancer commentedon Apr 25, 2013
Serhiy is pointing you to an existing use of heapq in the stdlib. I'm not quite sure what his intent is in pointing it out, though it *might* be to point out that heapq is a primitive, and PriorityQueue already implements a subclassable class using it.
I don't personally have any opinion either way on the utility of your proposed classes. I've only ever used PriorityQueue once :)
allyourcode commentedon Apr 25, 2013
Ah, Serhiy is pointing out that there's already a class named PriorityQueue in the queue module. I didn't know that exists.
Now that I've had a chance to look at it, queue.PriorityQueue is like my Heap class, but there are some interesting difference; moreover, I'm also proposing DynamicHeap, which is pretty different from PriorityQueue. Perhaps, I should find a way to augment PriorityQueue so that it supports the interesting features of DynamicHeap?
pitrou commentedon Apr 26, 2013
queue.PriorityQueue is a locked class for use in multi-threaded code. That's like saying Queue is a good substitute for list :-)
OTOH, the proposed patch raises a lot of warning signs for me. I will wait for a decision on the feature's desirability before making a review.
serhiy-storchaka commentedon Apr 26, 2013
From my multilingual experience I can say that priority queue is very rarely used type of collections (but if it needed it is very usefull). On one hand, Python stdlib already contains one such type, and this type will be good enough in non-performance-critical applications. On other hand, a non-locked implementation using heapq is trivial (just encapsulate a list inside a class), no one will implement it wrong (if do not over-complicate the interface). I don't see the need for yet one priority queue. The presence of two very similar types in the stdlib will lead to confusion.
serhiy-storchaka commentedon Apr 27, 2013
See also rejected bpo-1162363.
rhettinger commentedon Apr 29, 2013
Daniel, I've already been in the process of adding a class to the heapq module and have done substantial work on it over the last few months. I'll look at your code to see if there are any ideas that should be merged with it before I finish it up.
Am attaching my current draft for Heap(). A PriorityQueue() variant would also be added to 3.4.
rhettinger commentedon Apr 29, 2013
Daniel, I'm going to close this one so we can continue work in just a single tracker item: http://bugs.python.org/issue13742
I'll see if anything in your code should be merged in to mine and will list you as a co-contributor when it all goes in.