Bug report
Bug description:
make patchcheck fails to find the upstream remote in a partial clone (git clone --filter=blob:none ...), even when the remote is named upstream and points at https://github.com/python/cpython:
ValueError: Patchcheck was unable to find an unambiguous upstream remote, with URL matching 'https://github.com/python/cpython'. For help creating an upstream remote, see Dev Guide: https://devguide.python.org/getting-started/git-boot-camp/#cloning-a-forked-cpython-repository
Remotes found:
origin https://github.com/ekanshul/cpython.git (fetch)
Since Git 2.37 (git/git@ef6d15ca53), git remote -v appends the object filter of a promisor remote to its fetch line:
$ git remote -v
origin https://github.com/ekanshul/cpython.git (fetch)
origin https://github.com/ekanshul/cpython.git (push)
upstream https://github.com/python/cpython.git (fetch) [blob:none]
upstream https://github.com/python/cpython.git (push)
get_git_upstream_remote() in Tools/patchcheck/patchcheck.py (from #135806) selects fetch lines with remote.endswith("(fetch)"), so the partially-cloned upstream is dropped both from the candidates and from the "Remotes found" list in the error message, which makes the message misleading too. Matching "(fetch)" anywhere on the line fixes it.
CPython versions tested on:
CPython main branch
Operating systems tested on:
macOS (git 2.50.1)
Linked PRs
Bug report
Bug description:
make patchcheckfails to find the upstream remote in a partial clone (git clone --filter=blob:none ...), even when the remote is namedupstreamand points athttps://github.com/python/cpython:Since Git 2.37 (git/git@ef6d15ca53),
git remote -vappends the object filter of a promisor remote to its fetch line:get_git_upstream_remote()inTools/patchcheck/patchcheck.py(from #135806) selects fetch lines withremote.endswith("(fetch)"), so the partially-clonedupstreamis dropped both from the candidates and from the "Remotes found" list in the error message, which makes the message misleading too. Matching"(fetch)"anywhere on the line fixes it.CPython versions tested on:
CPython main branch
Operating systems tested on:
macOS (git 2.50.1)
Linked PRs