Skip to content

Refactor tail-call.yml  #144552

@savannahostrowski

Description

@savannahostrowski

LGTM - I do have more meta comments about existing patterns in the workflow file though:

  • I'm wondering if x86_64-pc-windows-msvc/msvc-free-threading would be more consistent with the triple/compiler pattern.
  • It might be a bit more robust to use a matrix variable here like free-threading: true? If we add more FT variants later, this could get a bit hairy.

Not a problem to solve in this PR since both of these are leveraging existing patterns but maybe some futureproofing we should consider.

Originally posted by @savannahostrowski in #144550 (review)

Linked PRs

Metadata

Metadata

Labels

infraCI, GitHub Actions, buildbots, Dependabot, etc.type-refactorCode refactoring (with no changes in behavior)

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions