Skip to content

pystats should compare opcode counts by name, not number #109330

@mdboom

Description

@mdboom

Bug report

Bug description:

When Tools/scripts/summarize_stats.py is used to compare two stats .json files, it compares opcode counts by the opcode number, not the opcode name. This is a problem when comparing between two commits where the opcode numbers have changed (due to adding or removing opcodes).

If stats instead:

  1. Emitted the opcode name rather than the number
  2. summarize_stats.py used names rather than numbers

we should have something much more robust.

Cc @brandtbucher

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs

Metadata

Metadata

Assignees

Labels

performancePerformance or resource usagetype-bugAn unexpected behavior, bug, or error

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions