-
-
Notifications
You must be signed in to change notification settings - Fork 34.4k
pystats should compare opcode counts by name, not number #109330
Copy link
Copy link
Closed
Labels
performancePerformance or resource usagePerformance or resource usagetype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error
Description
Bug report
Bug description:
When Tools/scripts/summarize_stats.py is used to compare two stats .json files, it compares opcode counts by the opcode number, not the opcode name. This is a problem when comparing between two commits where the opcode numbers have changed (due to adding or removing opcodes).
If stats instead:
- Emitted the opcode name rather than the number
- summarize_stats.py used names rather than numbers
we should have something much more robust.
CPython versions tested on:
CPython main branch
Operating systems tested on:
No response
Linked PRs
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
performancePerformance or resource usagePerformance or resource usagetype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error