Merged revisions 79270 via svnmerge from

benjaminp · benjaminp · commit f8197c3489ff · 2010-03-22T02:02:37.000Z
svn+ssh://pythondev@svn.python.org/python/trunk

........
  r79270 | michael.foord | 2010-03-21 20:56:54 -0500 (Sun, 21 Mar 2010) | 1 line

  expected failure should not trigger failfast behavior in unittest.
........
diff --git a/Lib/test/test_unittest.py b/Lib/test/test_unittest.py
@@ -2125,12 +2125,6 @@ def testFailFast(self):
         result.addUnexpectedSuccess(None)
         self.assertTrue(result.shouldStop)
 
-        result = unittest.TestResult()
-        result._exc_info_to_string = lambda *_: ''
-        result.failfast = True
-        result.addExpectedFailure(None, None)
-        self.assertTrue(result.shouldStop)
-
     def testFailFastSetByRunner(self):
         runner = unittest.TextTestRunner(stream=io.StringIO(), failfast=True)
         def test(result):
diff --git a/Lib/unittest/main.py b/Lib/unittest/main.py
@@ -178,7 +178,7 @@ def runTests(self):
                 testRunner = self.testRunner(verbosity=self.verbosity,
                                              failfast=self.failfast)
             except TypeError:
-                # didn't accept the verbosity or failfast argument
+                # didn't accept the verbosity or failfast arguments
                 testRunner = self.testRunner()
         else:
             # it is assumed to be a TestRunner instance
diff --git a/Lib/unittest/result.py b/Lib/unittest/result.py
@@ -81,7 +81,6 @@ def addSkip(self, test, reason):
         """Called when a test is skipped."""
         self.skipped.append((test, reason))
 
-    @failfast
     def addExpectedFailure(self, test, err):
         """Called when an expected failure/error occured."""
         self.expectedFailures.append(
