Fixed an off-by-one error in _PyUnicode_EqualToASCIIString (issue #28701).

serhiy-storchaka · serhiy-storchaka · commit df66b9c425f9 · 2016-11-16T16:12:56.000+02:00
diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c
@@ -11070,7 +11070,7 @@ non_ready_unicode_equal_to_ascii_string(PyObject *unicode, const char *str)
     assert(p);
     for (i = 0; i < len; i++) {
         unsigned char c = (unsigned char)str[i];
-        if (c > 128 || p[i] != (wchar_t)c)
+        if (c >= 128 || p[i] != (wchar_t)c)
             return 0;
     }
     return 1;

Original file line number	Diff line number	Diff line change
`@@ -11070,7 +11070,7 @@ non_ready_unicode_equal_to_ascii_string(PyObject unicode, const char str)`
`11070`	`11070`	`assert(p);`
`11071`	`11071`	`for (i = 0; i < len; i++) {`
`11072`	`11072`	`unsigned char c = (unsigned char)str[i];`
`11073`		`- if (c > 128 \|\| p[i] != (wchar_t)c)`
	`11073`	`+ if (c >= 128 \|\| p[i] != (wchar_t)c)`
`11074`	`11074`	`return 0;`
`11075`	`11075`	`}`
`11076`	`11076`	`return 1;`