Issue #25410: Fixed a memory leak in OrderedDict in the case when key's hash

serhiy-storchaka · serhiy-storchaka · commit d17427b7bd69 · 2015-10-20T18:21:48.000+03:00
calculation fails.
diff --git a/Objects/odictobject.c b/Objects/odictobject.c
@@ -648,11 +648,11 @@ _odict_add_new_node(PyODictObject *od, PyObject *key)
     Py_ssize_t i;
     _ODictNode *node;
 
-    Py_INCREF(key);
     hash = PyObject_Hash(key);
     if (hash == -1)
         return -1;
 
+    Py_INCREF(key);
     i = _odict_get_index(od, key);
     if (i < 0) {
         if (!PyErr_Occurred())
