bpo-32680 add default "sock" on SMTP objects

romuald · romuald · commit ba97bdfa8e91 · 2018-01-26T17:26:19.000+01:00
By default the smtplib.SMTP objects did not have a sock attribute, it
was only created during connect()
diff --git a/Lib/smtplib.py b/Lib/smtplib.py
@@ -216,6 +216,8 @@ class SMTP:
         method called 'sendmail' that will do an entire mail transaction.
         """
     debuglevel = 0
+
+    sock = None
     file = None
     helo_resp = None
     ehlo_msg = "ehlo"
@@ -344,7 +346,7 @@ def send(self, s):
         """Send `s' to the server."""
         if self.debuglevel > 0:
             self._print_debug('send:', repr(s))
-        if hasattr(self, 'sock') and self.sock:
+        if self.sock:
             if isinstance(s, str):
                 # send is used by the 'data' command, where command_encoding
                 # should not be used, but 'data' needs to convert the string to
