Fixed PyObject_Vectorcall() call and SQL placeholder.

felixxm · felixxm · commit b1ae087a0b75 · 2024-01-24T09:43:44.000+01:00
diff --git a/Lib/sqlite3/dump.py b/Lib/sqlite3/dump.py
@@ -34,7 +34,7 @@ def _iterdump(connection, *, filter=None):
 
     if filter:
         # Return database objects which match the filter pattern.
-        filter_name_clause = 'AND "name" LIKE %s'
+        filter_name_clause = 'AND "name" LIKE ?'
         params = [filter]
     else:
         filter_name_clause = ""
@@ -97,7 +97,7 @@ def _iterdump(connection, *, filter=None):
             "type" IN ('index', 'trigger', 'view')
             {filter_name_clause}
         """
-    schema_res = cu.execute(q)
+    schema_res = cu.execute(q, params)
     for name, type, sql in schema_res.fetchall():
         yield('{0};'.format(sql))
 
diff --git a/Modules/_sqlite/connection.c b/Modules/_sqlite/connection.c
@@ -2003,8 +2003,10 @@ pysqlite_connection_iterdump_impl(pysqlite_Connection *self,
         }
         return NULL;
     }
-    PyObject *args[1] = {(PyObject *)self};
-    PyObject *retval = PyObject_Vectorcall(iterdump, args, 1, filter);
+    PyObject *args[2] = {(PyObject *)self, filter};
+    PyObject *kwnames = PyTuple_New(1);
+    PyTuple_SET_ITEM(kwnames, 0, PyUnicode_FromString("filter"));
+    PyObject *retval = PyObject_Vectorcall(iterdump, args, 1, kwnames);
     Py_DECREF(iterdump);
     return retval;
 }

Original file line number	Diff line number	Diff line change
`@@ -2003,8 +2003,10 @@ pysqlite_connection_iterdump_impl(pysqlite_Connection *self,`
`2003`	`2003`	`}`
`2004`	`2004`	`return NULL;`
`2005`	`2005`	`}`
`2006`		`- PyObject args[1] = {(PyObject )self};`
`2007`		`- PyObject *retval = PyObject_Vectorcall(iterdump, args, 1, filter);`
	`2006`	`+ PyObject args[2] = {(PyObject )self, filter};`
	`2007`	`+ PyObject *kwnames = PyTuple_New(1);`
	`2008`	`+ PyTuple_SET_ITEM(kwnames, 0, PyUnicode_FromString("filter"));`
	`2009`	`+ PyObject *retval = PyObject_Vectorcall(iterdump, args, 1, kwnames);`
`2008`	`2010`	`Py_DECREF(iterdump);`
`2009`	`2011`	`return retval;`
`2010`	`2012`	`}`