bpo-32681: Fix an uninitialized variable in the C implementation of os.dup2

matrixise · matrixise · commit a92b6800a626 · 2018-01-26T17:31:22.000+01:00
diff --git a/Misc/NEWS.d/next/C API/2018-01-26-17-29-29.bpo-32681.N1ruWa.rst b/Misc/NEWS.d/next/C API/2018-01-26-17-29-29.bpo-32681.N1ruWa.rst
@@ -0,0 +1,2 @@
+Fix uninitialized variable 'res' in the C implementation of os.dup2. Patch
+by Stéphane Wirtel
diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c
@@ -7782,7 +7782,7 @@ static int
 os_dup2_impl(PyObject *module, int fd, int fd2, int inheritable)
 /*[clinic end generated code: output=bc059d34a73404d1 input=c3cddda8922b038d]*/
 {
-    int res;
+    int res = 0;
 #if defined(HAVE_DUP3) && \
     !(defined(HAVE_FCNTL_H) && defined(F_DUP2FD_CLOEXEC))
     /* dup3() is available on Linux 2.6.27+ and glibc 2.9 */

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+Fix uninitialized variable 'res' in the C implementation of os.dup2. Patch`
	`2`	`+by Stéphane Wirtel`
Original file line number	Diff line number	Diff line change
`@@ -7782,7 +7782,7 @@ static int`
`7782`	`7782`	`os_dup2_impl(PyObject *module, int fd, int fd2, int inheritable)`
`7783`	`7783`	`/[clinic end generated code: output=bc059d34a73404d1 input=c3cddda8922b038d]/`
`7784`	`7784`	`{`
`7785`		`- int res;`
	`7785`	`+ int res = 0;`
`7786`	`7786`	`#if defined(HAVE_DUP3) && \`
`7787`	`7787`	`!(defined(HAVE_FCNTL_H) && defined(F_DUP2FD_CLOEXEC))`
`7788`	`7788`	`/* dup3() is available on Linux 2.6.27+ and glibc 2.9 */`